maedhroz commented on code in PR #2961:
URL: https://github.com/apache/cassandra/pull/2961#discussion_r1420898784
##########
src/java/org/apache/cassandra/service/reads/thresholds/CoordinatorWarnings.java:
##########
@@ -147,14 +152,14 @@ private static void clearState()
@FunctionalInterface
private interface ToString
{
- String apply(int count, long value, String cql);
+ String apply(ImmutableSet<InetAddressAndPort> nodes, long value,
String cql);
Review Comment:
I mean, you could leave it, but then you a.) have change the message in
`tombstoneAbortMessage()` et al. and b.) might have to deal w/ printing an
arbitrarily large set of nodes, right? (You could like, truncate at 3 nodes or
something...)
I'm guessing the original intent (CC @dcapwell) was to let users see the
problem in aggregate and then hit the logs to see what nodes exactly were
having issues. I'd vote for either leaving things as they are or printing a
truncated list of problematic nodes in the implementations of `ToString`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
