maedhroz commented on code in PR #2961:
URL: https://github.com/apache/cassandra/pull/2961#discussion_r1420909032
##########
src/java/org/apache/cassandra/db/guardrails/GuardrailsMBean.java:
##########
@@ -770,4 +770,40 @@ public interface GuardrailsMBean
* {@code 20m}, {@code 30h} or {@code 40d}. A {@code
null} value means disabled.
*/
void setMinimumTimestampThreshold(@Nullable String warnDuration, @Nullable
String failDuration);
+
+ /**
+ * @return The threshold to warn when number of referenced indexes for
non-partition restricted query is
+ * greater than treshold.
+ */
+ int
getMaximumReferencedIndexesForNonPartitionRestrictedQueryWarnThreshold();
+
+ /**
+ * @return The threshold to fail when number of referenced indexes to be
searched for non-partition restricted
+ * query is greater than treshold.
+ */
+ int
getMaximumReferencedIndexesForNonPartitionRestrictedQueryFailThreshold();
+
+ /**
+ * Sets the warning and failure threshold for a guardrail checking number
of referenced indexes searched
+ * for non-partition restricted queries.
+ * @param warn value to set for warn threshold
+ * @param fail value to set for fail threshold
+ */
+ void
setMaximumReferencedIndexesForNonPartitionRestrictedQueryThreshold(int warn,
int fail);
+
+ /**
+ * Returns whether it is possible to execute a query against indexes
without specifying
+ * any partition key restrictions.
+ *
+ * @return true if it is possible to execute a query without a partition
key, false otherwise
+ */
+ boolean getNonPartitionRestrictedQueryEnabled();
+
+ /**
+ * Sets whether it is possible to execute a query against indexes without
specifying
+ * any partition key restrictions.
+ *
+ * @param enabled {@code true} if a query without partition key is enabled
or not
+ */
+ void setNonPartitionRestrictedQueryEnabled(boolean enabled);
Review Comment:
nit: Nothing super urgent here...just come back at the end and make sure
things are named in a consistent way, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
