maedhroz commented on code in PR #2961:
URL: https://github.com/apache/cassandra/pull/2961#discussion_r1420920426
##########
src/java/org/apache/cassandra/metrics/KeyspaceMetrics.java:
##########
@@ -275,6 +279,10 @@ public KeyspaceMetrics(final Keyspace ks)
rowIndexSizeAborts = createKeyspaceMeter("RowIndexSizeAborts");
rowIndexSize = createKeyspaceHistogram("RowIndexSize", false);
+ tooManyIndexReadSSTablesWarnings =
createKeyspaceMeter("TooManyIndexReadSSTablesWarnings");
+ tooManyIndexReadSSTablesAborts =
createKeyspaceMeter("TooManyIndexReadSSTablesAborts");
+ tooManyIndexReadSSTables =
createKeyspaceHistogram("TooManyIndexReadSSTables", false);
Review Comment:
I noticed we already have this histogram in
`TableQueryMetrics.PerQueryMetrics.sstablesHit` BUT (and @mike-tr-adamson can
correct me here) it looks like it's only updated for top-k queries? We should
probably just make sure update that for all queries and just remove this
`TooManyIndexReadSSTables` histogram.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
