maedhroz commented on code in PR #2961:
URL: https://github.com/apache/cassandra/pull/2961#discussion_r1420976427
##########
src/java/org/apache/cassandra/db/ReadCommand.java:
##########
@@ -425,11 +425,14 @@ public UnfilteredPartitionIterator
executeLocally(ReadExecutionController execut
.collect(Collectors.joining(",")));
}
- UnfilteredPartitionIterator iterator = (null == searcher) ?
queryStorage(cfs, executionController) : searcher.search(executionController);
Review Comment:
I don't think there's actually anything in `RTBoundValidator.validate()`
that can throw, and in the previous line, we'll fail before we even get an
iterator. I'd revert this, at least as part of this patch. Even if we really
wanted to change it, I think we'd just want to a.) move only `validate()` into
the `try` and b.) remove the unnecessary `iterator == null` check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
