smiklosovic commented on code in PR #2961:
URL: https://github.com/apache/cassandra/pull/2961#discussion_r1420938200
##########
src/java/org/apache/cassandra/service/reads/thresholds/CoordinatorWarnings.java:
##########
@@ -147,14 +152,14 @@ private static void clearState()
@FunctionalInterface
private interface ToString
{
- String apply(int count, long value, String cql);
+ String apply(ImmutableSet<InetAddressAndPort> nodes, long value,
String cql);
Review Comment:
Rather to keep it as it was before then truncating it. I dont like to
truncate it. BTW I dont think it would be too long anyway ... what RF you have
out there at most? 5? 9? And not all replicas are going to violate ... it is
not like this list would be practically without a reasonable limit.
##########
src/java/org/apache/cassandra/service/reads/thresholds/CoordinatorWarnings.java:
##########
@@ -147,14 +152,14 @@ private static void clearState()
@FunctionalInterface
private interface ToString
{
- String apply(int count, long value, String cql);
+ String apply(ImmutableSet<InetAddressAndPort> nodes, long value,
String cql);
Review Comment:
Rather to keep it as it was before than truncating it. I don't like to
truncate it. BTW I don't think it would be too long anyway ... what RF you have
out there at most? 5? 9? And not all replicas are going to violate ... it is
not like this list would be practically without a reasonable limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
