Claudenw commented on code in PR #2966:
URL: https://github.com/apache/cassandra/pull/2966#discussion_r1422030905
##########
test/unit/org/apache/cassandra/db/compaction/unified/ControllerTest.java:
##########
@@ -207,11 +209,13 @@ public void testGetNumShards()
Map<String, String> options = new HashMap<>();
options.putIfAbsent(Controller.BASE_SHARD_COUNT_OPTION,
Integer.toString(3));
options.putIfAbsent(Controller.TARGET_SSTABLE_SIZE_OPTION,
FBUtilities.prettyPrintMemory(100 << 20));
- options.put(Controller.MIN_SSTABLE_SIZE_OPTION, "0B");
options.put(Controller.SSTABLE_GROWTH_OPTION, "0.0");
Controller.validateOptions(options);
+ // this is a provably invalid setting but required for this test.
Review Comment:
should be fixed in the latest code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
