ethan-brown2022 commented on code in PR #2966:
URL: https://github.com/apache/cassandra/pull/2966#discussion_r1422878417
##########
src/java/org/apache/cassandra/db/compaction/unified/Controller.java:
##########
@@ -596,10 +598,10 @@ public static Map<String, String>
validateOptions(Map<String, String> options) t
try
{
long sizeInBytes = FBUtilities.parseHumanReadableBytes(s);
- if (sizeInBytes < 0)
- throw new ConfigurationException(String.format("Invalid
configuration, %s should be positive: %s",
+ if (sizeInBytes < targetSSTableSize)
Review Comment:
The purpose of the `min_sstable_size` option is to only split sstables over
shards if they are at least as large as `min_sstable_size`. If it is set,
fewer than `base_shard_count` shards will be created to ensure that the
estimated size of each sstable is at least `min_sstable_size`, but once there
is enough data, the number of shards will be such that the size of each sstable
is between $t / \sqrt 2$ and $t \cdot \sqrt 2$ (assuming sstable_growth = 0).
The goal of this ticket is to verify that `min_sstable_size` is less than
the lower bound ($t / \sqrt 2$).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
