Claudenw commented on code in PR #2966:
URL: https://github.com/apache/cassandra/pull/2966#discussion_r1422040954
##########
src/java/org/apache/cassandra/db/compaction/unified/Controller.java:
##########
@@ -596,10 +598,10 @@ public static Map<String, String>
validateOptions(Map<String, String> options) t
try
{
long sizeInBytes = FBUtilities.parseHumanReadableBytes(s);
- if (sizeInBytes < 0)
- throw new ConfigurationException(String.format("Invalid
configuration, %s should be positive: %s",
+ if (sizeInBytes < targetSSTableSize)
Review Comment:
@ethan-brown2022 I am thinking there should be 3 checks:
( min_sstable_size < $t \cdot \sqrt 2$ && min_sstable_size > $t / \sqrt 2$
) || (min_sstable_size = 0)
We have not discussed adding $t / \sqrt 2$ as a check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
