bereng commented on PR #2990: URL: https://github.com/apache/cassandra/pull/2990#issuecomment-1855495759
The new full coverage is nice. Wouldn't you like to preserve the section you removed commented with `This code won't run until 2086`? I know it doesn't nothing for the test _but_ it helps greatly understand what the test is doing. Otherwise it's a loose end and open door for a future reader to be wondering what about that. It's almost like documentation. I would at least add a comment to help a future reader close the circle and connect all the dots. Wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
