bereng commented on code in PR #2990:
URL: https://github.com/apache/cassandra/pull/2990#discussion_r1426550287
##########
test/distributed/org/apache/cassandra/distributed/upgrade/MixedModeTTLOverflowUpgradeTest.java:
##########
@@ -169,6 +169,15 @@ private static void testTTLOverflow(RunOnClusterAndNode
runAfterNodeUpgrade) thr
.run();
}
+ /**
+ * Verifies that the TTL overflow policy triggers at the correct limit for
a variety types
+ * @param step the step in the upgrade process (manily use a unique
primary key for each verification)
+ * @param cluster the cluster
+ * @param expectPolicyTriggerAt2038 when true, we expect the overflow
policy to trigger at 2038 and attempts to set
+ * a TTL which would result in expiration
date after 2038 to fail. Otherwise, the
+ * allowed expiration date is 2106, and
we cannot test that for now because of
+ * {@link Attributes#MAX_TTL} limit of 20
years.
Review Comment:
Nice thanks for adding it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
