bereng commented on code in PR #2990:
URL: https://github.com/apache/cassandra/pull/2990#discussion_r1426552796
##########
test/distributed/org/apache/cassandra/distributed/upgrade/MixedModeTTLOverflowUpgradeTest.java:
##########
@@ -18,64 +18,96 @@
package org.apache.cassandra.distributed.upgrade;
+import java.util.List;
+import java.util.function.BiConsumer;
+import java.util.stream.Stream;
+
import org.junit.Test;
import org.apache.cassandra.cql3.Attributes;
-import org.apache.cassandra.db.rows.Cell;
import org.apache.cassandra.distributed.UpgradeableCluster;
import org.apache.cassandra.distributed.api.ICoordinator;
import org.apache.cassandra.utils.Clock;
import org.apache.cassandra.utils.StorageCompatibilityMode;
import org.assertj.core.api.Assertions;
+import org.assertj.core.data.Offset;
import static org.apache.cassandra.distributed.api.ConsistencyLevel.ALL;
+import static org.apache.cassandra.distributed.api.ConsistencyLevel.LOCAL_ONE;
import static org.apache.cassandra.utils.StorageCompatibilityMode.NONE;
import static org.apache.cassandra.utils.StorageCompatibilityMode.UPGRADING;
+import static org.assertj.core.api.Assertions.assertThat;
/**
- * Tests TTL the overflow policy triggers at the correct limit: year 2038 <=nb
or 2186 >=oa
+ * Tests TTL the overflow policy triggers at the correct limit
* <p>
- * <=oa overflow policy triggers at year 2038. That could be <=4.1 or 5.0 with
4.x storage compatibility
- * >oa overflow policy triggers at year 2106. That is >=5.0 using >=5.x
storage compatibility
+ * sstable version < BIG:oa, overflow policy triggers at year 2038. That could
be <=4.1 or 5.0 with 4.x storage compatibility
+ * sstable version >= BIG:oa or BTI - overflow policy triggers at year 2106.
That is >=5.0 using no storage compatibility
*
* @see StorageCompatibilityMode
*/
public class MixedModeTTLOverflowUpgradeTest extends UpgradeTestBase
{
+ private static final int SMALL_TTL = 3600;
+
+ private static final String T_REGULAR = "table_regular";
+ private static final String T_CLUST = "table_clust";
+ private static final String T_STATIC = "table_static";
+ private static final String T_COMPLEX = "table_complex";
+ private static final String T_FROZEN = "table_frozen";
+ private static final String T_INDEX = "table_indexed";
+ private static final String INDEX = "idx";
+ private static final String TYPE = "complex_type";
+
+ private static final int NODE_1_MAX_TTL_KEY_OFFSET = 1000;
+ private static final int NODE_2_MAX_TTL_KEY_OFFSET = 2000;
+ private static final int NODE_1_MIXED_TTL_KEY_OFFSET = 3000;
+ private static final int NODE_2_MIXED_TTL_KEY_OFFSET = 4000;
+
+ enum Step
+ {
+ NODE1_PREV_NODE2_PREV,
+ NODE1_40_NODE2_PREV,
+ NODE1_UPGRADING_NODE2_PREV,
+ NODE1_40_NODE2_40,
Review Comment:
I would remove references to specific versions here as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
