adelapena commented on code in PR #2989:
URL: https://github.com/apache/cassandra/pull/2989#discussion_r1431371439


##########
src/java/org/apache/cassandra/index/sai/disk/v1/bbtree/BlockBalancedTreeWriter.java:
##########
@@ -130,26 +132,26 @@ public int getMaxPointsInLeafNode()
     }
 
     /**
-     * Write the sorted values from a {@link BlockBalancedTreeIterator}.
+     * Write the sorted values from an {@link Iterator}.
      * <p>
      * @param treeOutput The {@link IndexOutput} to write the balanced tree to
-     * @param values The {@link BlockBalancedTreeIterator} containing the 
values and rowIDs to be written
+     * @param iterator The {@link Iterator} containing the values and rowIDs 
to be written

Review Comment:
   It would be good to specify whether the index entries are expected to be 
sorted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to