mike-tr-adamson commented on code in PR #2989:
URL: https://github.com/apache/cassandra/pull/2989#discussion_r1431266666
##########
src/java/org/apache/cassandra/index/sai/disk/v1/segment/SegmentRamBuffer.java:
##########
@@ -73,9 +73,9 @@ public long add(int segmentRowId, byte[] value)
return (trie.sizeOnHeap() - initialSizeOnHeap) +
(postingsAccumulator.heapAllocations() - reducerHeapSize);
}
- public BlockBalancedTreeIterator iterator()
+ public SegmentRamIterator iterator()
{
- return
BlockBalancedTreeIterator.fromTrieIterator(trie.entrySet().iterator(),
bytesPerValue);
+ return SegmentRamIterator.fromTrieIterator(trie.entrySet().iterator());
Review Comment:
I have removed `SegmentRamIterator` and made `TermsIterator` an
`Interator<IndexEntry>`. This has simplified things a lot. `SegmentRamBuffer`
is now `SegmentTrieBuffer`. `IndexEntry` is preferred because that is used in
the internal index to represent the same thing. So we are keeping common
terminology.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
