adelapena commented on code in PR #2989:
URL: https://github.com/apache/cassandra/pull/2989#discussion_r1431357222
##########
src/java/org/apache/cassandra/index/sai/disk/v1/segment/SegmentBuilder.java:
##########
@@ -73,103 +67,53 @@ public abstract class SegmentBuilder
private ByteBuffer minTerm;
private ByteBuffer maxTerm;
- final IndexTermType indexTermType;
+ final StorageAttachedIndex index;
long totalBytesAllocated;
int rowCount = 0;
int maxSegmentRowId = -1;
- public static class BlockBalancedTreeSegmentBuilder extends SegmentBuilder
+ public static class RamBufferSegmentBuilder extends SegmentBuilder
{
- private final byte[] scratch;
- private final BlockBalancedTreeRamBuffer trieBuffer;
+ protected final SegmentTrieBuffer segmentRamBuffer;
Review Comment:
The var should be named `segmentTrieBuffer`, in line with the new class
name. Or maybe just `buffer`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
