yifan-c commented on code in PR #88:
URL: https://github.com/apache/cassandra-sidecar/pull/88#discussion_r1440735224
##########
src/main/java/org/apache/cassandra/sidecar/routes/AbstractHandler.java:
##########
@@ -93,6 +93,7 @@ public void handle(RoutingContext context)
catch (Exception exception)
{
processFailure(exception, context, host, remoteAddress, null);
+ return;
Review Comment:
Instead of `return` from the catch block, how about moving the
`handleInternal` call inside the try block? So that it catches any exception
throw during `handleInternal`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
