nvharikrishna commented on code in PR #88:
URL: https://github.com/apache/cassandra-sidecar/pull/88#discussion_r1440748262
##########
src/main/java/org/apache/cassandra/sidecar/routes/AbstractHandler.java:
##########
@@ -93,6 +93,7 @@ public void handle(RoutingContext context)
catch (Exception exception)
{
processFailure(exception, context, host, remoteAddress, null);
+ return;
Review Comment:
If `handlerInternal` moved to try block, then processFailure will end up
handling expections of `handleInternal` method too. As per my understand,
processFailure is only for processing the failures of request parsing/exptract
params. If `processFailure` starts handling `handlerInternal` exceptions too,
too then isn't it a change of behavior for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
