yifan-c commented on code in PR #88:
URL: https://github.com/apache/cassandra-sidecar/pull/88#discussion_r1440866336
##########
src/main/java/org/apache/cassandra/sidecar/routes/AbstractHandler.java:
##########
@@ -93,6 +93,7 @@ public void handle(RoutingContext context)
catch (Exception exception)
{
processFailure(exception, context, host, remoteAddress, null);
+ return;
Review Comment:
I believe the intent here is to have a common catch block for any exception
during `handle`. Moving `handlerInternal` inside the try block is the desired
correction of the behavior.
Maybe @frankgh can comment here, as you are the original author of the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
