maedhroz commented on code in PR #2935:
URL: https://github.com/apache/cassandra/pull/2935#discussion_r1442397879


##########
src/java/org/apache/cassandra/db/filter/RowFilter.java:
##########
@@ -68,19 +68,22 @@ public abstract class RowFilter implements 
Iterable<RowFilter.Expression>
 
     protected final List<Expression> expressions;
 
-    protected RowFilter(List<Expression> expressions)
+    private final boolean isStrict;

Review Comment:
   This property being a part of the row filter is one of the big decisions 
made in this patch. One of the reasons it felt appropriate is that `RowFilter` 
itself is still broken around CASSANDRA-19007. The property being present here 
might make it easier for the logic below to adjust. I'm not sure if that 
belongs in this Jira, but if there is a clear path to fixing it, perhaps I can 
create another one and fast-follow after I commit this patch?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to