maedhroz commented on code in PR #2935:
URL: https://github.com/apache/cassandra/pull/2935#discussion_r1442398865
##########
src/java/org/apache/cassandra/cql3/restrictions/StatementRestrictions.java:
##########
@@ -779,7 +779,12 @@ public RowFilter getRowFilter(IndexRegistry indexRegistry,
QueryOptions options)
if (filterRestrictions.isEmpty())
return RowFilter.none();
- RowFilter filter = RowFilter.create();
+ ConsistencyLevel cl = options.getConsistency();
+ boolean isStrict = cl == ConsistencyLevel.ONE || cl ==
ConsistencyLevel.LOCAL_ONE || cl == ConsistencyLevel.NODE_LOCAL
+ // With zero or one restricted mutable columns,
strict filtering is safe even at higher consistency levels.
+ ||
nonPrimaryKeyRestrictions.getColumnDefinitions().size() <= 1;
Review Comment:
I think this is all we can do at the coordinator, before we know anything
about the local data we need to search. Any other cases I'm missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
