blambov commented on code in PR #2896:
URL: https://github.com/apache/cassandra/pull/2896#discussion_r1448562932
##########
test/distributed/org/apache/cassandra/distributed/test/UpgradeSSTablesTest.java:
##########
@@ -59,8 +59,8 @@ public void upgradeSSTablesInterruptsOngoingCompaction()
throws Throwable
cluster.get(1).acceptsOnInstance((String ks) -> {
ColumnFamilyStore cfs =
Keyspace.open(ks).getColumnFamilyStore("tbl");
cfs.disableAutoCompaction();
- CompactionManager.instance.setMaximumCompactorThreads(1);
CompactionManager.instance.setCoreCompactorThreads(1);
+ CompactionManager.instance.setMaximumCompactorThreads(1);
Review Comment:
Because the previous order was invalid (if the core is e.g. 4 and you set
the max to 1, it's an invalid operation). Reducing the core first is the
correct way to do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
