blambov commented on code in PR #2896:
URL: https://github.com/apache/cassandra/pull/2896#discussion_r1448570846
##########
test/distributed/org/apache/cassandra/distributed/impl/InstanceConfig.java:
##########
@@ -114,6 +115,47 @@ private InstanceConfig(int num,
.set("counter_cache_size", "50MiB")
.set("key_cache_size", "50MiB")
.set("commitlog_disk_access_mode", "legacy");
+ if
(CassandraRelevantProperties.DTEST_JVM_DTESTS_USE_LATEST.getBoolean())
+ {
+ // TODO: make this load latest_diff.yaml or cassandra_latest.yaml
Review Comment:
Not if the non-latest path does not read any configuration file either.
Both need to be fixed to read a config file (possibly applying changes on
top of it), but my quick attempt to do it failed and I don't want to delay the
introduction and testing of the "latest" config (and 5.0 with it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
