iamaleksey commented on code in PR #2982:
URL: https://github.com/apache/cassandra/pull/2982#discussion_r1453624938
##########
src/java/org/apache/cassandra/service/accord/AccordVerbHandler.java:
##########
@@ -52,45 +48,34 @@ public void doVerb(Message<T> message) throws IOException
// TODO (desired): need a non-blocking way to inform CMS of an unknown
epoch and add callback to it's receipt
// ClusterMetadataService.instance().maybeCatchup(message.epoch());
logger.debug("Receiving {} from {}", message.payload, message.from());
+ Node.Id fromNodeId = endpointMapper.mappedId(message.from());
T request = message.payload;
+
long knownEpoch = request.knownEpoch();
if (!node.topology().hasEpoch(knownEpoch))
{
node.configService().fetchTopologyForEpoch(knownEpoch);
long waitForEpoch = request.waitForEpoch();
Review Comment:
Correct. Removing its uses from here, and will remove the method from Accord
core in the sister PR as well. Simplified some related logic here, reducing
nesting and a redundant call to `fetchTopologyForEpoch()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
