aweisberg commented on code in PR #2982:
URL: https://github.com/apache/cassandra/pull/2982#discussion_r1453697640
##########
src/java/org/apache/cassandra/service/accord/AccordJournal.java:
##########
@@ -1271,9 +1259,9 @@ private static abstract class AuxiliaryRecord
private static final class FrameRecord extends AuxiliaryRecord
{
- final Pointer[] pointers;
+ final List<Pointer> pointers;
- FrameRecord(Timestamp timestamp, Pointer[] pointers)
+ FrameRecord(Timestamp timestamp, List<Pointer> pointers)
Review Comment:
It looks like a frame record is basically just a list of pointers, and the
timestamp in the frame record is unused right now?
For the pointers could you use collection serializer instead of hand rolling
the serialization?
Would it make sense to only have the list of pointers and no frame record
class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
