aweisberg commented on code in PR #2982:
URL: https://github.com/apache/cassandra/pull/2982#discussion_r1453711916
##########
src/java/org/apache/cassandra/service/accord/AccordJournal.java:
##########
@@ -1123,17 +1111,17 @@ private void doRun()
}
else
{
- requestBuffer.add(request);
+ if (null == requests) requests = new ArrayList<>();
Review Comment:
Hard to say without knowing the actual inputs for this in practice, but
`requests` might actually make more sense to have a fixed buffer. One thing you
might want to do is artificially constrain frame size to some cache friendly
number. I'll bet allocate and copy is plenty fast in that situation, and faster
than doing even a few resizes.
But if this is always pretty small then it doesn't help much, but also
doesn't hurt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
