Mmuzaf commented on code in PR #3002:
URL: https://github.com/apache/cassandra/pull/3002#discussion_r1467941059
##########
src/java/org/apache/cassandra/auth/AuthCache.java:
##########
@@ -225,6 +235,7 @@ public V get(K k)
if (cache == null)
return loadFunction.apply(k);
+ metrics.requests.mark();
Review Comment:
Aren't we missing the `getAll` path for tracking requests here? The
`ChunkCache` itself encapsulates this logic in the `StatsCounter`. It's worth
adding such a test or a verification the metrics value for existing tests in
`AuthCacheTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
