Mmuzaf commented on code in PR #3002:
URL: https://github.com/apache/cassandra/pull/3002#discussion_r1467809092
##########
test/unit/org/apache/cassandra/auth/AuthCacheTest.java:
##########
@@ -322,6 +322,41 @@ public void
testCacheLoaderIsNotCalledOnGetAllWhenCacheIsNotEmpty()
assertEquals(1, loadCounter);
}
+ @Test
+ public void testMetricsOnCacheEnabled()
Review Comment:
Should we also check the numbers for the `entries' and `maxEntries' method
calls? They do not seem to be covered by the tests.
##########
test/unit/org/apache/cassandra/auth/AuthCacheTest.java:
##########
@@ -322,6 +322,41 @@ public void
testCacheLoaderIsNotCalledOnGetAllWhenCacheIsNotEmpty()
assertEquals(1, loadCounter);
}
+ @Test
+ public void testMetricsOnCacheEnabled()
Review Comment:
Should we also check the numbers for the `entries' and `maxEntries` method
calls? They do not seem to be covered by the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
