Mmuzaf commented on code in PR #3002: URL: https://github.com/apache/cassandra/pull/3002#discussion_r1462316038
########## src/java/org/apache/cassandra/metrics/UnweightedCacheMetrics.java: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.cassandra.metrics; + +import com.codahale.metrics.Gauge; +import org.apache.cassandra.cache.UnweightedCacheSize; + +import static org.apache.cassandra.metrics.CassandraMetricsRegistry.Metrics; + +/** + * Metrics for an unweighted cache like {@code AuthCache}. + */ +public class UnweightedCacheMetrics extends AbstractCacheMetrics Review Comment: AuthCache metrics are valuable in their own right, though, so I'm not sure we need an additional 'unweighted' category for them. The simpler it is, the better it will be. We can move this question to the issue for visibility. @beobal I think it was your original idea to organise classes in this way. wdyt ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
