jakubzytka commented on code in PR #3102:
URL: https://github.com/apache/cassandra/pull/3102#discussion_r1489416616
##########
src/java/org/apache/cassandra/metrics/DecayingEstimatedHistogramReservoir.java:
##########
@@ -250,7 +248,7 @@ public void update(long value)
int index = findIndex(bucketOffsets, value);
- updateBucket(decayingBuckets, index,
Math.round(forwardDecayWeight(now)));
+ decayingBuckets.update(index, now);
Review Comment:
I'm on the fence with this one.
On the one hand, I don't want to do a direct `decayingBuckets.buckets`
update because the weight may be given incorrectly.
On the other, it looks inconsistent with updating regular buckets, and there
is no separation of concerns in DEHR anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
