Mmuzaf commented on code in PR #3102:
URL: https://github.com/apache/cassandra/pull/3102#discussion_r1713957479
##########
src/java/org/apache/cassandra/metrics/DecayingEstimatedHistogramReservoir.java:
##########
@@ -430,19 +430,64 @@ public void rebase(EstimatedHistogramReservoirSnapshot
snapshot)
}
}
- this.decayLandmark = snapshot.snapshotLandmark;
+ DecayingBuckets newDecayingBuckets = new
DecayingBuckets(snapshot.snapshotLandmark);
for (int i = 0; i < size(); i++)
{
// set rebased values in the first stripe and clear out all other
data
- decayingBuckets.set(stripedIndex(i, 0),
snapshot.decayingBuckets[i]);
+ newDecayingBuckets.buckets.set(stripedIndex(i, 0),
snapshot.decayingBuckets[i]);
buckets.set(stripedIndex(i, 0), snapshot.values[i]);
for (int stripe = 1; stripe < nStripes; stripe++)
{
- decayingBuckets.set(stripedIndex(i, stripe), 0);
+ newDecayingBuckets.buckets.set(stripedIndex(i, stripe), 0);
buckets.set(stripedIndex(i, stripe), 0);
}
}
+ decayingBuckets = newDecayingBuckets;
Review Comment:
I think it's the same as here:
https://github.com/apache/cassandra/pull/3102/files#r1713929010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
