jakubzytka commented on PR #3102: URL: https://github.com/apache/cassandra/pull/3102#issuecomment-1946115074
> LGTM. The change doesn't incur performance penalty and should fix the correctness problem. Skipping a very tiny fraction of data is much smaller problem than inserting vastly incorrect data into histogram due to a race. WRT performance. The results of `LatencyTrackingBench` have a lot of uncertainty, but if anything, they show a possible improvement in `update` throughput. It makes sense, as the number of volatile reads is reduced to 1 (using `decayLandmark` is no longer a volatile read) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
