smiklosovic commented on code in PR #3168:
URL: https://github.com/apache/cassandra/pull/3168#discussion_r1542629708
##########
src/java/org/apache/cassandra/schema/TableParams.java:
##########
@@ -490,6 +490,11 @@ public Builder extensions(Map<String, ByteBuffer> val)
public static class Serializer implements MetadataSerializer<TableParams>
{
+ private final String keyspace;
Review Comment:
I dont think this is a good idea, because then you have `new Serializer...."
everywhere. These serializers are meant to be effectively singletons, rather
put `keyspace` as parameter of the method instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
