smiklosovic commented on code in PR #3168:
URL: https://github.com/apache/cassandra/pull/3168#discussion_r1549854451


##########
src/java/org/apache/cassandra/schema/TableParams.java:
##########
@@ -490,6 +490,11 @@ public Builder extensions(Map<String, ByteBuffer> val)
 
     public static class Serializer implements MetadataSerializer<TableParams>
     {
+        private final String keyspace;

Review Comment:
   hah I realized that ....
   
   
       cqlsh> ALTER TABLE system.local WITH compression = {'class': 
'ZstdCompressor'};
       Unauthorized: Error from server: code=2100 [Unauthorized] 
message="system keyspace is not user-modifiable."
   
   So we are already covered on that front. But if somebody wanted to set that 
programmatically, we can do this:
   
   
https://github.com/Claudenw/cassandra/pull/12/commits/ea26c2e8cf684563dc88d909dd02ba9c2669b62b



##########
src/java/org/apache/cassandra/schema/TableParams.java:
##########
@@ -490,6 +490,11 @@ public Builder extensions(Map<String, ByteBuffer> val)
 
     public static class Serializer implements MetadataSerializer<TableParams>
     {
+        private final String keyspace;

Review Comment:
   @Claudenw (@michaelsembwever )
   
   hah I realized that ....
   
   
       cqlsh> ALTER TABLE system.local WITH compression = {'class': 
'ZstdCompressor'};
       Unauthorized: Error from server: code=2100 [Unauthorized] 
message="system keyspace is not user-modifiable."
   
   So we are already covered on that front. But if somebody wanted to set that 
programmatically, we can do this:
   
   
https://github.com/Claudenw/cassandra/pull/12/commits/ea26c2e8cf684563dc88d909dd02ba9c2669b62b



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to