jacek-lewandowski commented on PR #3168: URL: https://github.com/apache/cassandra/pull/3168#issuecomment-2039468284
> However, doing this led to an issue where System tables should not have the default table compression applied. In order to support this the TableParams.builder needs to know the keyspace name when building so that it can be passed to the CompressonParams.builder where the filter for determining which tables get the old DEFAULT and which get the new calculated default Compression params is handled by the CompressionParams.defaultParams(keyspace) method. > This change in turn led to changes to several files where the keyspace name needed to be provided for the TableParams.builder().build() function call. Actually why do we need all of those changes? System tables are not something which magically appear in the system - they are created explicitly and we can explicitly set compression to none when creating them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
