smiklosovic commented on code in PR #3168:
URL: https://github.com/apache/cassandra/pull/3168#discussion_r1549884164


##########
src/java/org/apache/cassandra/schema/TableParams.java:
##########
@@ -490,6 +490,11 @@ public Builder extensions(Map<String, ByteBuffer> val)
 
     public static class Serializer implements MetadataSerializer<TableParams>
     {
+        private final String keyspace;

Review Comment:
   @Claudenw after my changes, that "partiallyBuild" is not necessary, I have 
remove that  
https://github.com/Claudenw/cassandra/pull/12/commits/20c790a255f89da08506b728a8170d36d6ef6865
   
   so, we are not having partially anywhere, we are not putting keyspace 
anywhere, we are checking that system is always on default and ser/de is not 
touched at all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to