frankgh commented on code in PR #111:
URL: https://github.com/apache/cassandra-sidecar/pull/111#discussion_r1561840020
##########
src/main/java/org/apache/cassandra/sidecar/metrics/instance/UploadSSTableMetrics.java:
##########
@@ -55,8 +62,9 @@ public static class UploadSSTableComponentMetrics
{
protected final MetricRegistry metricRegistry;
public final String sstableComponent;
- public final NamedMetric<Meter> rateLimitedCalls;
- public final NamedMetric<Meter> diskUsageHigh;
+ public final NamedMetric<DefaultSettableGauge<Integer>>
rateLimitedCalls;
+ public final NamedMetric<DefaultSettableGauge<Integer>> diskUsageHigh;
Review Comment:
It doesn't make much sense to track high disk usage on a per component
basis. Maybe a drive makes sense, but it doesn't make sense for a specific
component
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
