sarankk commented on code in PR #111:
URL: https://github.com/apache/cassandra-sidecar/pull/111#discussion_r1561874010
##########
src/main/java/org/apache/cassandra/sidecar/metrics/instance/UploadSSTableMetrics.java:
##########
@@ -71,15 +79,21 @@ public UploadSSTableComponentMetrics(MetricRegistry
metricRegistry, String sstab
NamedMetric.Tag componentTag = NamedMetric.Tag.of("component",
sstableComponent);
rateLimitedCalls
- = NamedMetric.builder(metricRegistry::meter)
+ = NamedMetric.builder(name -> metricRegistry.gauge(name, () -> new
DefaultSettableGauge<>(0)))
Review Comment:
Moved them out. But I feel for highDiskUsage it might be valuable to keep
component detail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
