frankgh commented on code in PR #111:
URL: https://github.com/apache/cassandra-sidecar/pull/111#discussion_r1561840700
##########
src/main/java/org/apache/cassandra/sidecar/config/yaml/VertxMetricsConfigurationImpl.java:
##########
@@ -32,34 +29,28 @@ public class VertxMetricsConfigurationImpl implements
VertxMetricsConfiguration
public static final boolean DEFAULT_ENABLED = true;
public static final boolean DEFAULT_EXPOSE_VIA_JMX = false;
public static final String DEFAULT_JMX_DOMAIN_NAME =
"sidecar.vertx.jmx_domain";
- public static final List<String> DEFAULT_MONITORED_SERVER_ROUTE_REGEXES =
Collections.singletonList("/api/v1/.*");
Review Comment:
should we add it in `sidecar.yaml` then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
