smiklosovic commented on code in PR #3241:
URL: https://github.com/apache/cassandra/pull/3241#discussion_r1565478380
##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -903,11 +903,18 @@ public static void setClientMode(boolean clientMode)
public volatile boolean zero_ttl_on_twcs_warned = true;
public volatile boolean zero_ttl_on_twcs_enabled = true;
public volatile boolean non_partition_restricted_index_query_enabled =
true;
- public volatile int sai_sstable_indexes_per_query_warn_threshold = 32;
- public volatile int sai_sstable_indexes_per_query_fail_threshold = -1;
public volatile boolean intersect_filtering_query_warned = true;
public volatile boolean intersect_filtering_query_enabled = true;
+ public volatile int sai_sstable_indexes_per_query_warn_threshold = 32;
+ public volatile int sai_sstable_indexes_per_query_fail_threshold = -1;
+ public volatile DataStorageSpec.LongBytesBound
sai_string_term_size_warn_threshold = new
DataStorageSpec.LongBytesBound("1KiB");
Review Comment:
by the way ... where are all these values for defaults coming from? I am not
necessarily arguing the sizes as such, I am curious based on what we put these
sizes there? Is that some kind of an empirical observation or something else?
Shouldn't we just put everywhere "0" so people will make their minds about the
sizes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
