maedhroz commented on code in PR #3241:
URL: https://github.com/apache/cassandra/pull/3241#discussion_r1566024162
##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -903,11 +903,18 @@ public static void setClientMode(boolean clientMode)
public volatile boolean zero_ttl_on_twcs_warned = true;
public volatile boolean zero_ttl_on_twcs_enabled = true;
public volatile boolean non_partition_restricted_index_query_enabled =
true;
- public volatile int sai_sstable_indexes_per_query_warn_threshold = 32;
- public volatile int sai_sstable_indexes_per_query_fail_threshold = -1;
public volatile boolean intersect_filtering_query_warned = true;
public volatile boolean intersect_filtering_query_enabled = true;
+ public volatile int sai_sstable_indexes_per_query_warn_threshold = 32;
+ public volatile int sai_sstable_indexes_per_query_fail_threshold = -1;
+ public volatile DataStorageSpec.LongBytesBound
sai_string_term_size_warn_threshold = new
DataStorageSpec.LongBytesBound("1KiB");
Review Comment:
So you'll notice the frozen and vector fail thresholds are just the previous
system property maxes:
https://github.com/apache/cassandra/pull/3241/files#diff-32a8b4fa02cda1ef5a7216fe68d70d23a9784a4bb33b1230d2ec776140dae3d7L428
For strings, I bumped the fail threshold to a number @JeremiahDJordan had
mentioned in Slack that Astra was using as a fail threshold (and left the
previous max as the new warning threshold).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
