maedhroz commented on code in PR #3241:
URL: https://github.com/apache/cassandra/pull/3241#discussion_r1565993860
##########
src/java/org/apache/cassandra/config/GuardrailsOptions.java:
##########
@@ -1164,8 +1164,8 @@ private static void validateWarnLowerThanFail(long warn,
long fail, String name)
return;
if (fail < warn)
- throw new IllegalArgumentException(format("The warn threshold %d
for %s_warn_threshold should not be " +
- "higher than the fail
threshold %d", warn, name, fail));
+ throw new IllegalArgumentException(format("The warn threshold %d
for %s_warn_threshold should be lower " +
+ "than the fail threshold
%d", warn, name, fail));
Review Comment:
@adelapena @bereng @smiklosovic I don't really want to fix it in this patch,
but the check and the warning message don't strictly agree. Either it should be
`if (fail <= warn)` or the error message needs to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
