dcapwell commented on code in PR #96:
URL: https://github.com/apache/cassandra-accord/pull/96#discussion_r1633769176
##########
accord-core/src/main/java/accord/local/SerializerSupport.java:
##########
@@ -88,6 +87,7 @@ public class SerializerSupport
ImmutableSet.<MessageType>builder()
.addAll(PRE_ACCEPT_STABLE_TYPES)
.addAll(APPLY_TYPES)
+ .add(PROPAGATE_OTHER_MSG)
Review Comment:
is this true? `accord.messages.Propagate#type`
```
@Override
public MessageType type()
{
// TODO (now): this logic doesn't work now we permit upgrading; need
to pick the maximum *possible* status we might propagate
// might be better to
switch (achieved.propagatesStatus())
{
case Applied:
case PreApplied:
if (toEpoch >= committedExecuteAt.epoch())
return MessageType.PROPAGATE_APPLY_MSG;
case Committed:
case Stable:
return MessageType.PROPAGATE_STABLE_MSG;
case PreCommitted:
if (!achieved.definition.isKnown())
return MessageType.PROPAGATE_OTHER_MSG;
case PreAccepted:
return MessageType.PROPAGATE_PRE_ACCEPT_MSG;
default:
return MessageType.PROPAGATE_OTHER_MSG;
}
}
```
if we reach applied we would be `PROPAGATE_STABLE_MSG` or
`PROPAGATE_APPLY_MSG`. This means that the only cases where this happens are
below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
