belliottsmith commented on code in PR #96:
URL: https://github.com/apache/cassandra-accord/pull/96#discussion_r1634740146
##########
accord-core/src/main/java/accord/messages/ApplyThenWaitUntilApplied.java:
##########
@@ -87,9 +87,9 @@ public ApplyThenWaitUntilApplied(Node.Id to, Topologies
topologies, Timestamp ex
this.notify = notify == null ? null : notify.slice(slice);
}
- protected ApplyThenWaitUntilApplied(TxnId txnId, Participants<?>
readScope, long executeAtEpoch, Timestamp executeAt, FullRoute<?> route,
PartialTxn txn, PartialDeps deps, Writes writes, Result result, Seekables<?, ?>
notify)
+ protected ApplyThenWaitUntilApplied(TxnId txnId, Participants<?>
readScope, Timestamp executeAt, FullRoute<?> route, PartialTxn txn, PartialDeps
deps, Writes writes, Result result, Seekables<?, ?> notify)
{
- super(txnId, readScope, executeAtEpoch);
Review Comment:
iirc ExclusiveSyncPoints maybe supply a different execution epoch. BUT I
need to revisit how ExclusiveSyncPoints are executed anyway, to simplify some
other stuff (and also fix some minor correctness issues across range
movements). So, if this doesn't clearly break anything don't worry about it,
they'll get their own dedicated execution class when I do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
