dcapwell commented on code in PR #96:
URL: https://github.com/apache/cassandra-accord/pull/96#discussion_r1633776106
##########
accord-core/src/test/java/accord/impl/list/ListStore.java:
##########
@@ -512,6 +513,8 @@ public static AsyncChain<SyncPoint<Ranges>> coordinate(Node
node, long minEpoch,
Await coordinate = new Await(node, minEpoch, sp);
coordinate.start();
return coordinate.recover(t -> {
+ if (t.getClass() == SyncPointErased.class)
+ return AsyncChains.success(null);
Review Comment:
this code is consistent with the rest of the function, so its fine... but
relooking at it `return AsyncChains.success(null)` feels wrong as the only
caller doesn't handle that case! Its there for debug logging, so if we
actually log we will hit a NPE I think...
nothing for you to change as you are consistent... but a bad access will
lead to a NPE if we hit this or `Redundant`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
