aweisberg commented on code in PR #96:
URL: https://github.com/apache/cassandra-accord/pull/96#discussion_r1635521252


##########
accord-core/src/main/java/accord/local/SerializerSupport.java:
##########
@@ -88,6 +87,7 @@ public class SerializerSupport
     ImmutableSet.<MessageType>builder()
                 .addAll(PRE_ACCEPT_STABLE_TYPES)
                 .addAll(APPLY_TYPES)
+                .add(PROPAGATE_OTHER_MSG)

Review Comment:
   Then what is the code in `SerializerSupport` supposed to be doing with 
`PROPAGATE_OTHER_MSG`? Because right now it's doesn't process it at all.
   
   I can create a new type for truncated or invalidated, but then 
PROPAGATE_OTHER_MSG will be a no-op again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to