yifan-c commented on code in PR #126:
URL: https://github.com/apache/cassandra-sidecar/pull/126#discussion_r1635601847
##########
vertx-client-shaded/build.gradle:
##########
@@ -83,6 +83,8 @@ shadowJar {
}
}
+test.dependsOn shadowJar
Review Comment:
```
LibraryTest > Ensures that the shading is correct for the
vertx-client-shaded project FAILED
```
It is to fix the flaky test, `LibraryTest`. The test requires shadow jar
being built. However, when the test runs, the jar is empty.
That being said, test already depends on shadowJar. It needs a different
fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
