yifan-c commented on code in PR #126: URL: https://github.com/apache/cassandra-sidecar/pull/126#discussion_r1636778653
########## gradlew: ########## @@ -105,8 +105,10 @@ if [ "$cygwin" = "false" -a "$darwin" = "false" -a "$nonstop" = "false" ] ; then fi # For Darwin, add options to specify how the application appears in the dock +# In addition, we want to disable the MaxFDLimit for MacOS, which is set to a lower limit than the actual system maximum. Review Comment: No. The max FD constant for macOS is low. It is `OPEN_MAX == 10240` https://github.com/openjdk/jdk/blob/dfd3da3f52480f68f653beb1e720691f8232ace7/src/hotspot/os/bsd/os_bsd.cpp#L1997-L2002 You want to _disable_ the max FD, so that it can pick up the system's limit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
