frankgh commented on code in PR #126: URL: https://github.com/apache/cassandra-sidecar/pull/126#discussion_r1635836629
########## gradlew: ########## @@ -105,8 +105,10 @@ if [ "$cygwin" = "false" -a "$darwin" = "false" -a "$nonstop" = "false" ] ; then fi # For Darwin, add options to specify how the application appears in the dock +# In addition, we want to disable the MaxFDLimit for MacOS, which is set to a lower limit than the actual system maximum. Review Comment: I noticed there are places where we enable the flag, and other places where we disable the flag. Is that intentional? Reading this documentation: https://docs.oracle.com/cd/E19683-01/806-7930/filestructure-11/index.html it looks like setting the flag i.e. doing `-XX:+MaxFDLimit` should `Bump the number of file descriptors to max`. Isn't this what we are trying to accomplish here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
