aweisberg commented on code in PR #101:
URL: https://github.com/apache/cassandra-accord/pull/101#discussion_r1662914421


##########
accord-core/src/main/java/accord/topology/TopologyManager.java:
##########
@@ -371,17 +395,86 @@ private int indexOf(long epoch)
         }
     }
 
+    private static class FutureEpoch
+    {
+        private volatile AsyncResult.Settable<Void> future;
+        private long deadlineMillis;
+
+        public FutureEpoch(long deadlineMillis)
+        {
+            this.future = AsyncResults.settable();
+            this.deadlineMillis = deadlineMillis;

Review Comment:
   That makes sense. We don't expose that to Accord right now, but I could add 
it as something like `elapsedTime` which is elapsed time since some arbitrary 
point and then use that for things that rely on time. For test code it would be 
the same time progression as `currentTimeMillis`
   
   Durability scheduling also uses `currentTimeMillis` indirectly so it would 
also benefit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to