dcapwell commented on code in PR #101:
URL: https://github.com/apache/cassandra-accord/pull/101#discussion_r1663158278
##########
accord-core/src/main/java/accord/impl/CoordinateDurabilityScheduling.java:
##########
@@ -214,10 +215,15 @@ private void run()
private void startShardSync(Ranges ranges)
{
TxnId at = node.nextTxnId(ExclusiveSyncPoint, Domain.Range);
- node.scheduler().once(() -> node.withEpoch(at.epoch(), () -> {
+ node.scheduler().once(() -> node.withEpoch(at.epoch(), (ignored,
withEpochFailure) -> {
+ if (withEpochFailure != null)
+ {
+ logger.trace("Exception waiting for epoch
before coordinating exclusive sync point for local shard durability, epoch {}:
{}", at.epoch(), getStackTraceAsString(withEpochFailure));
+ return;
+ }
CoordinateSyncPoint.exclusive(node, at, ranges)
.addCallback((success, fail) -> {
- if (fail != null) logger.trace("Exception
coordinating exclusive sync point for local shard durability of {}", ranges,
fail);
+ if (fail != null) logger.trace("Exception
coordinating exclusive sync point for local shard durability of {}: {}",
ranges, getStackTraceAsString(fail));
Review Comment:
```
logger.info("What {} {}", "is", "happening", new Throwable());
```
produces
```
INFO [main] 2024-07-02 13:52:56,336 EpochGossipTest.java:95 - What is
happening
java.lang.Throwable: null
at
org.apache.cassandra.service.accord.EpochGossipTest.main(EpochGossipTest.java:95)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
