aweisberg commented on code in PR #101:
URL: https://github.com/apache/cassandra-accord/pull/101#discussion_r1662998444
##########
accord-core/src/main/java/accord/local/Node.java:
##########
@@ -738,7 +725,10 @@ public void receive(Request request, Id from, ReplyContext
replyContext)
if (waitForEpoch > topology.epoch())
{
configService.fetchTopologyForEpoch(waitForEpoch);
- topology().awaitEpoch(waitForEpoch).addCallback(() ->
receive(request, from, replyContext));
+ topology().awaitEpoch(waitForEpoch).addCallback((ignored, failure)
-> {
Review Comment:
How though? The agent already got notified of the timeout. We are going to
drop the message, and when we drop messages we don't normally send a response.
The error handling for this dropped message will be somewhere else that
relies on the message to be received to make progress and will already have its
own timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
